[Asterisk-code-review] rest-api: Tests for external media (...testsuite[16])

Kevin Harwell asteriskteam at digium.com
Tue Sep 3 17:33:47 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/12783 )

Change subject: rest-api:  Tests for external media
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/12783/2/tests/rest_api/channels/external_media/nominal/create_with_vars.py 
File tests/rest_api/channels/external_media/nominal/create_with_vars.py:

https://gerrit.asterisk.org/#/c/12783/2/tests/rest_api/channels/external_media/nominal/create_with_vars.py@28 
PS2, Line 28:     
red blob/whitespace


https://gerrit.asterisk.org/#/c/12783/2/tests/rest_api/channels/external_media/off-nominal/test-config.yaml 
File tests/rest_api/channels/external_media/off-nominal/test-config.yaml:

https://gerrit.asterisk.org/#/c/12783/2/tests/rest_api/channels/external_media/off-nominal/test-config.yaml@36 
PS2, Line 36: #        -   conditions:
            : #                match:
            : #                    type: StasisEnd
            : #                    application: testsuite
            : #                    channel:
            : #                       name: '^Local'
            : #            count: 1
            : #            stop_test:
Remove this unused commented section.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/12783
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I0ebd6bc75ea853ba5912bdf300dd60af8bb76ae8
Gerrit-Change-Number: 12783
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 03 Sep 2019 22:33:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190903/e2f19241/attachment.html>


More information about the asterisk-code-review mailing list