[Asterisk-code-review] pjsip mwi: Add a few more tests for solicited mwi subscriptinons (...testsuite[master])

Kevin Harwell asteriskteam at digium.com
Tue Sep 3 09:52:29 CDT 2019


Hello Friendly Automation, George Joseph, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/testsuite/+/12820

to look at the new patch set (#2).

Change subject: pjsip mwi: Add a few more tests for solicited mwi subscriptinons
......................................................................

pjsip mwi: Add a few more tests for solicited mwi subscriptinons

Added some tests to ensure that the "mwi_subscribe_replaces_unsolicited" option
works as it should. The tests make sure aggregation is also handled correctly
when enabled.

A couple tests make sure that a solicited subscription is able to replace
an unsolicited subscription when appropriate. A couple of other tests make
sure that if the unsolicited is created after the solicited one then the
solicited subscription is shutdown, and the unsolicited one is allowed.

Lastly, one test makes sure that when a solicited subscription replaces an
unsolicited one then when the contact is updated no extra MWI messages are
sent out.

ASTERISK-28488

Change-Id: I50ebd212789249f14056b8b3948304237a5f1042
---
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/configs/ast1/pjsip.conf
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/sipp/solicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/sipp/unsolicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/configs/ast1/pjsip.conf
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/sipp/solicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/sipp/unsolicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/tests.yaml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/aggregate/configs/ast1/pjsip.conf
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/aggregate/sipp/solicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/aggregate/sipp/unsolicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/aggregate/test-config.yaml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/multiple_registers/configs/ast1/pjsip.conf
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/multiple_registers/sipp/solicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/multiple_registers/sipp/unsolicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/multiple_registers/test-config.yaml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/non_aggregate/configs/ast1/pjsip.conf
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/non_aggregate/sipp/solicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/non_aggregate/sipp/unsolicited.xml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/non_aggregate/test-config.yaml
A tests/channels/pjsip/subscriptions/mwi/solicited/replaces_unsolicited/tests.yaml
A tests/channels/pjsip/subscriptions/mwi/solicited/tests.yaml
M tests/channels/pjsip/subscriptions/mwi/tests.yaml
24 files changed, 1,454 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/20/12820/2
-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/12820
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: I50ebd212789249f14056b8b3948304237a5f1042
Gerrit-Change-Number: 12820
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190903/16a70ef9/attachment.html>


More information about the asterisk-code-review mailing list