[Asterisk-code-review] various files - fix some alerts raised by lgtm code analysis (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13102 )

Change subject: various files - fix some alerts raised by lgtm code analysis
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/13102/1/include/asterisk/channel_internal.h 
File include/asterisk/channel_internal.h:

https://gerrit.asterisk.org/#/c/13102/1/include/asterisk/channel_internal.h@21 
PS1, Line 21: #ifndef _ASTERISK_CHANNEL_INTERNAL_H
So I hate to be pedantic, but C99 says:

 All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.

I know we use the single underscore in other header files and the chances of collision are fairly low, but it's something to keep in mind.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13102
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25
Gerrit-Change-Number: 13102
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 23 Oct 2019 21:57:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191023/23a54b49/attachment.html>