[Asterisk-code-review] feat: AudioSocket channel, application, and ARI support. (...asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel, application, and ARI support.
......................................................................


Patch Set 25:

(2 comments)

https://gerrit.asterisk.org/#/c/11579/25/res/ari/resource_channels.c 
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/#/c/11579/25/res/ari/resource_channels.c@2145 
PS25, Line 2145: 	struct ast_json *json_chan;
Don't need this anymore


https://gerrit.asterisk.org/#/c/11579/25/res/ari/resource_channels.c@2175 
PS25, Line 2175: 	json_chan = response->message;
               : 	response->message = ast_json_object_create();
               : 	if (!response->message) {
               : 		ast_channel_unref(chan);
               : 		ast_json_unref(json_chan);
               : 		ast_ari_response_alloc_failed(response);
               : 		return;
               : 	}
               : 
               : 	ast_json_object_set(response->message, "channel", json_chan);
               : 	ast_channel_lock(chan);
               : 	vars = ast_channel_varshead(chan);
               : 	if (vars && !AST_LIST_EMPTY(vars)) {
               : 		ast_json_object_set(json_chan, "channelvars", ast_json_channel_vars(vars));
               : 	}
Don't need this anymore.  After you rebase this against current master, use the same logic as rtp_udp.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 25
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Tue, 22 Oct 2019 12:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191022/179fd2ae/attachment-0001.html>