[Asterisk-code-review] res_pjsip_messaging: Rewrite To: to normalize recipient (...asterisk[13])

Brian J. Murrell asteriskteam at digium.com
Tue Oct 22 06:27:42 CDT 2019


Brian J. Murrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13065 )

Change subject: res_pjsip_messaging:  Rewrite To: to normalize recipient
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 2: Code-Review+1

Thanks Joshua.  Is there another review needed before this can move on?  Just want to wait until it's completely reviewed before making the needed changes to the other branches.

https://gerrit.asterisk.org/#/c/13065/1/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/#/c/13065/1/res/res_pjsip_messaging.c@46 
PS1, Line 46: #include "asterisk/paths.h"
> Odd, I selected that line - but yes. I don't think it's really useful even as a debug message.
Done.  I'm going to wait until this one has received enough +1s before applying the same changes to the other branches.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iab8d472081d22ed80a3abf3b34833d898306ac8e
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 2
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 22 Oct 2019 11:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brian J. Murrell <brian at interlinx.bc.ca>
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191022/bc43e36e/attachment.html>


More information about the asterisk-code-review mailing list