[Asterisk-code-review] res_pjsip_messaging: Rewrite To: to normalize recipient (...asterisk[13])

Joshua Colp asteriskteam at digium.com
Fri Oct 18 08:45:41 CDT 2019


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13065 )

Change subject: res_pjsip_messaging:  Rewrite To: to normalize recipient
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/13065/1/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/#/c/13065/1/res/res_pjsip_messaging.c@46 
PS1, Line 46: #include "asterisk/paths.h"
I don't think having a warning here is needed. Most people likely don't have a system name, and their environment isn't impacted by this. For example DPMA heavily uses messaging and isn't impacted by this, and I believe would spam the log.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iab8d472081d22ed80a3abf3b34833d898306ac8e
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 1
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 18 Oct 2019 13:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191018/78846185/attachment.html>


More information about the asterisk-code-review mailing list