[Asterisk-code-review] Crash during "pjsip show channelstats" execution (...asterisk[13])

Salah Ahmed asteriskteam at digium.com
Wed Oct 16 13:47:02 CDT 2019


Salah Ahmed has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13044 )

Change subject: Crash during "pjsip show channelstats" execution
......................................................................


Patch Set 3:

(1 comment)

> (1 comment)

https://gerrit.asterisk.org/#/c/13044/2/channels/pjsip/cli_commands.c 
File channels/pjsip/cli_commands.c:

https://gerrit.asterisk.org/#/c/13044/2/channels/pjsip/cli_commands.c@376 
PS2, Line 376: 	rtp = ao2_bump(media->rtp);
> So after checking the locking, when things are destroyed and such I don't think you need to do an ao […]
Removed the rtp instance ao2_bump



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13044
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ia918bfa3c8119060633e39b14852e8d983e0417e
Gerrit-Change-Number: 13044
Gerrit-PatchSet: 3
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Salah Ahmed <txrubel at gmail.com>
Gerrit-Comment-Date: Wed, 16 Oct 2019 18:47:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191016/f68b2d18/attachment.html>


More information about the asterisk-code-review mailing list