[Asterisk-code-review] app_voicemail.c: Support multiple file formats for forwarded messages. (...asterisk[13])

cmaj asteriskteam at digium.com
Mon Oct 14 16:03:40 CDT 2019


cmaj has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12981 )

Change subject: app_voicemail.c: Support multiple file formats for forwarded messages.
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> (4 comments)
> 
> Should we not fix the ODBC bug instead?

I think this would require storing multiple file formats into ODBC during initial voicemail deposit. But the only time the extra format is needed are when those messages get forwarded later on -- which could be never for a lot of messages.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12981
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I7321e7f7e7c58adbf41dd4fd7191c887b9b2eafd
Gerrit-Change-Number: 12981
Gerrit-PatchSet: 1
Gerrit-Owner: cmaj <chris at penguinpbx.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: cmaj <chris at penguinpbx.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 14 Oct 2019 21:03:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191014/345dc7e3/attachment.html>


More information about the asterisk-code-review mailing list