[Asterisk-code-review] Revert "app_voicemail: Cleanup stale lock files on module load" (...asterisk[13])

George Joseph asteriskteam at digium.com
Tue Oct 8 06:33:39 CDT 2019


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13017 )

Change subject: Revert "app_voicemail: Cleanup stale lock files on module load"
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

I'm wondering if we should also do an UPGRADE note.  On the fence.

https://gerrit.asterisk.org/#/c/13017/3/doc/CHANGES-staging/voicemail_lock_cleanup_revert.txt 
File doc/CHANGES-staging/voicemail_lock_cleanup_revert.txt:

https://gerrit.asterisk.org/#/c/13017/3/doc/CHANGES-staging/voicemail_lock_cleanup_revert.txt@8 
PS3, Line 8: 
Can you add a blurb that says something like...  "Users who require the lock files to be removed at startup should modify their startup scripts to do so before starting the asterisk process"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13017
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I3ff4ca983d8e753fe2971f3439bd154705693c41
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 08 Oct 2019 11:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191008/0212046a/attachment-0001.html>


More information about the asterisk-code-review mailing list