[Asterisk-code-review] res_pjsip/res_pjsip_mwi: use centralized serializer pools (...asterisk[master])

Kevin Harwell asteriskteam at digium.com
Mon Oct 7 16:55:03 CDT 2019


Hello Benjamin Keith Ford, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13005

to look at the new patch set (#3).

Change subject: res_pjsip/res_pjsip_mwi: use centralized serializer pools
......................................................................

res_pjsip/res_pjsip_mwi: use centralized serializer pools

Both res_pjsip and res_pjsip_mwi made use of serializer pools. However, they
both implemented their own serializer pool functionality that was pretty much
identical in each of the source files. This patch removes the duplicated code,
and uses the new 'ast_serializer_pool' object instead.

Additionally res_pjsip_mwi enables a shutdown group on the pool since if the
timing was right the module could be unloaded while taskprocessor threads still
needed to execute, thus causing a crash.

Change-Id: I959b0805ad024585bbb6276593118be34fbf6e1d
---
M include/asterisk/res_pjsip.h
M res/res_pjsip.c
M res/res_pjsip_mwi.c
3 files changed, 64 insertions(+), 194 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/05/13005/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13005
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I959b0805ad024585bbb6276593118be34fbf6e1d
Gerrit-Change-Number: 13005
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191007/c3aeec57/attachment.html>


More information about the asterisk-code-review mailing list