[Asterisk-code-review] res_pjsip_mwi: use an ao2_global object for mwi containers (...asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12998 )

Change subject: res_pjsip_mwi: use an ao2_global object for mwi containers
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/12998/2/res/res_pjsip_mwi.c 
File res/res_pjsip_mwi.c:

https://gerrit.asterisk.org/#/c/12998/2/res/res_pjsip_mwi.c@697 
PS2, Line 697: 	if (!container) {
> "ao2_find" does a NULL check already on the container already and returns NULL if it is, so you don' […]
I think I'll leave it since ao2_find asserts if the passed in container is NULL.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12998
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8f812286dc19a34916acacd71ce2ec26e1042047
Gerrit-Change-Number: 12998
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Thu, 03 Oct 2019 17:40:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191003/00840839/attachment.html>