[Asterisk-code-review] res_pjsip_mwi: use an ao2_global object for mwi containers (...asterisk[13])

Kevin Harwell asteriskteam at digium.com
Wed Oct 2 13:03:05 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12998 )

Change subject: res_pjsip_mwi: use an ao2_global object for mwi containers
......................................................................


Patch Set 1:

I posted some of this on asterisk-dev, but just in case you missed it here's the basic gist:

In the "use centralized serial pools" review (one previous in commit to this one) I made it so res_pjsip_mwi only uses its own serializer pool for taskprocessing, which is also now associated with a shutdown group. In theory this should wait for serializers to complete before unloading.

However, there is a case where if the mwi serializer pool does not properly initialize then the default sip serializer pool is used instead. So taking what you mentioned here, I've added a shutdown ref for that case. I put that change in the "use centralized serial pools" review.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12998
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8f812286dc19a34916acacd71ce2ec26e1042047
Gerrit-Change-Number: 12998
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 18:03:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191002/2f3a88cd/attachment.html>


More information about the asterisk-code-review mailing list