[Asterisk-code-review] channel.c: Resolve issue with receiving SIP INFO packets for DTMF (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13303 )

Change subject: channel.c: Resolve issue with receiving SIP INFO packets for DTMF
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.asterisk.org/c/asterisk/+/13303/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/13303/1//COMMIT_MSG@9 
PS1, Line 9: The problem is essentially the same as in ASTERISK-28245. Besides
Should we consider this patch the fix for the referenced issue (or really the duplicate linked issue that is still open ASTERISK-25214)?  Otherwise, the issue reference needs to have the - in it changed to ~ or _ to prevent the stupid plugin from messing with the wrong issue.


https://gerrit.asterisk.org/c/asterisk/+/13303/1//COMMIT_MSG@10 
PS1, Line 10: the direct media scenario we have an additionally scenario where a
s/additionally/additional/


https://gerrit.asterisk.org/c/asterisk/+/13303/1//COMMIT_MSG@15 
PS1, Line 15: understood properly especially when SIP INFO are sent quick after
s/are sent quick/messages are sent quickly/


https://gerrit.asterisk.org/c/asterisk/+/13303/1//COMMIT_MSG@22 
PS1, Line 22: events has to be buffered in the ast channel read queue and
s/has/have/



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13303
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I309bf61dd065c9978c8e48f5b9a936ab47de64c2
Gerrit-Change-Number: 13303
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 19:09:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191122/da9171b8/attachment.html>