[Asterisk-code-review] res_pjsip_t38: T.38 error correction mode selection at 200 ok received (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13180 )

Change subject: res_pjsip_t38: T.38 error correction mode selection at 200 ok received
......................................................................


Patch Set 2:

(1 comment)

> Hello Kevin,
> 
> I think ITU-T Recommendation explain it as well.
> https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-T.38-201009-S!!PDF-E&type=items
> In section, D.2.3.5 SDP parameter usage in SIP/SDP Offer/Answer negotiations, Table D.2 has those 3 cases explained as following,
> t38UDPNoEC: No secondary IPF packets will be sent. The number of secondary messages is set
> to zero in UDPTL.
> t38UDPRedundancy: Only redundant error correction messages may be sent.
> t38UDPFEC: The endpoints can use either redundancy or FEC error correction scheme. 
> 
> Thanks,
> Salah

Thanks for the info. I think based on that the logic then it seems correct. Just another question (posted as a comment on the patch) then.

https://gerrit.asterisk.org/c/asterisk/+/13180/2/res/res_pjsip_t38.c 
File res/res_pjsip_t38.c:

https://gerrit.asterisk.org/c/asterisk/+/13180/2/res/res_pjsip_t38.c@723 
PS2, Line 723: 			} else {
             : 				if (!pj_stricmp2(&attr->value, "t38UDPRedundancy")) {
             : 					ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_REDUNDANCY);
             : 				} else if (!pj_stricmp2(&attr->value, "t38UDPFEC")) {
             : 					ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_FEC);
             : 				} else {
             : 					ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_NONE);
             : 				}
             : 			}
Wouldn't the same logic you added above apply if the incoming SDP is from the remote re-invite?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13180
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I343c62253ea4c8b7ee17abbfb377a4d484a14b19
Gerrit-Change-Number: 13180
Gerrit-PatchSet: 2
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 19:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191120/498e1d26/attachment.html>