[Asterisk-code-review] app_senddtmf: Add receive mode to AMI Action PlayDTMF (testsuite[16])

lvl asteriskteam at digium.com
Wed Nov 20 03:21:20 CST 2019


lvl has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/13164 )

Change subject: app_senddtmf: Add receive mode to AMI Action PlayDTMF
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml 
File tests/manager/playdtmf/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml@52 
PS1, Line 52:         ami-events:
            :             count: 1
            :             conditions:
            :                 match:
            :                     Event: 'UserEvent'
            :                     UserEvent: 'valid'
> Not necessary I'd say as it currently does test the feature. […]
OK :) It still seems a little far fetched but I won't pass up on the chance to make the testcase more future-proof.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13164
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I50f29a7c86ad10ef0f94d1aebb6eca4d905b4ec4
Gerrit-Change-Number: 13164
Gerrit-PatchSet: 3
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 09:21:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Comment-In-Reply-To: lvl <digium at lvlconsultancy.nl>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191120/76f48f0b/attachment.html>


More information about the asterisk-code-review mailing list