[Asterisk-code-review] lib/python/asterisk/pcap/py Replace construct_legacy.protocols (testsuite[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/13222 )

Change subject: lib/python/asterisk/pcap/py Replace construct_legacy.protocols
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/c/testsuite/+/13222/2/lib/python/asterisk/test_case.py 
File lib/python/asterisk/test_case.py:

https://gerrit.asterisk.org/c/testsuite/+/13222/2/lib/python/asterisk/test_case.py@681 
PS2, Line 681: #   It _appears_ no tests use this method but we'll throw an exception
             : #   to catch tests we might have missed.
             :     
             : #        raise NotImplementedError()
> Looks like this one got missed. Comment, commented code, and whitespace can be removed.

That's odd.  I could swear I deleted the entire function.


https://gerrit.asterisk.org/c/testsuite/+/13222/2/lib/python/protocols/layer3/ipv4.py 
File lib/python/protocols/layer3/ipv4.py:

https://gerrit.asterisk.org/c/testsuite/+/13222/2/lib/python/protocols/layer3/ipv4.py@30 
PS2, Line 30:         lambda obj, ctx: obj * 4, 
> whitespace eol here as well
Done



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13222
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-Change-Id: Id38d01a2cd073b240fde909a38c95d69313bbbe7
Gerrit-Change-Number: 13222
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 17:04:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191119/bd6119a2/attachment.html>