[Asterisk-code-review] app_senddtmf: Add receive mode to AMI Action PlayDTMF (testsuite[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/13164 )

Change subject: app_senddtmf: Add receive mode to AMI Action PlayDTMF
......................................................................


Patch Set 2:

(1 comment)

Up to you whether to add the extra check (unless someone else wants to block on it). Otherwise when you feel this is ready please cherry pick to the 13, 17, and master branches.

https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml 
File tests/manager/playdtmf/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml@52 
PS1, Line 52:         ami-events:
            :             count: 1
            :             conditions:
            :                 match:
            :                     Event: 'UserEvent'
            :                     UserEvent: 'valid'
> I don't believe this is necessary? In the dialplan the "valid" and "invalid" events are exclusive, i […]
Not necessary I'd say as it currently does test the feature. However, adding an event for 'invalid' would make the test more robust, and help to guard against regressions. For example, let's say a future patch accidentally makes it so the two cases are not mutually exclusive, and the 'invalid' case/userevent gets triggered. The test would still pass since there is no event check for the 'invalid' userevent.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13164
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I50f29a7c86ad10ef0f94d1aebb6eca4d905b4ec4
Gerrit-Change-Number: 13164
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 16:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Comment-In-Reply-To: lvl <digium at lvlconsultancy.nl>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191119/de0b9777/attachment.html>