[Asterisk-code-review] app_senddtmf: Add receive mode to AMI Action PlayDTMF (asterisk[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13163 )

Change subject: app_senddtmf: Add receive mode to AMI Action PlayDTMF
......................................................................


Patch Set 4:

(1 comment)

> Patch Set 4:
> 
> (1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13163/1/apps/app_senddtmf.c 
File apps/app_senddtmf.c:

https://gerrit.asterisk.org/c/asterisk/+/13163/1/apps/app_senddtmf.c@175 
PS1, Line 175: 	if (ast_strlen_zero(receive_s)) {
             : 		receive = 0;
             : 	} else {
             : 		receive = abs(ast_true(receive_s));
             : 	}
             : 
             : 	if (receive) {
> Right, your suggestion works well, thanks :) FWIW I borrowed this style from one of the other manage […]
Usually we like to keep things limited to the specific change being made, unless it's a very minor change (like fixing a typo, etc.). That way, if a regression occurred, we can easily remove changes to determine the offending commit.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13163
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I183501297ae1dc294ae56b34acac9b0343eb2664
Gerrit-Change-Number: 13163
Gerrit-PatchSet: 4
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Mon, 18 Nov 2019 15:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Comment-In-Reply-To: lvl <digium at lvlconsultancy.nl>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191118/47a6011d/attachment.html>