[Asterisk-code-review] various files - fix some alerts raised by lgtm code analysis (asterisk[13])

Sean Bright asteriskteam at digium.com
Wed Nov 13 12:31:06 CST 2019


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13102 )

Change subject: various files - fix some alerts raised by lgtm code analysis
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13102/4/apps/app_dictate.c 
File apps/app_dictate.c:

https://gerrit.asterisk.org/c/asterisk/+/13102/4/apps/app_dictate.c@154 
PS4, Line 154: 			ast_free(path);
> What will happen on the first iteration of this loop, when path is NULL and has no memory allocated  […]
ast_free() is NULL safe



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13102
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25
Gerrit-Change-Number: 13102
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 18:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191113/2c754f29/attachment.html>


More information about the asterisk-code-review mailing list