[Asterisk-code-review] res_pjsip_messaging: Rewrite To: to normalize recipient (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13065 )

Change subject: res_pjsip_messaging:  Rewrite To: to normalize recipient
......................................................................


Patch Set 2: Code-Review-1

I'm a little concerned...
1.  I thought we talked in the issue about making this a configurable option.
2.  System Name isn't guaranteed to be a FQDN if autosystemname=no.  systemname="My Pbx" is perfectly valid.
3.  If the pbx is behind a NAT, the FQDN might not be something an admin wants to expose.
4.  What happens when the destination isn't an end-user?  If we send the MESSAGE to a provider do we want the To host to be the pbx?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iab8d472081d22ed80a3abf3b34833d898306ac8e
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 2
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 12:47:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191108/b47815fb/attachment.html>