[Asterisk-code-review] feat: AudioSocket channel, application, and ARI support. (asterisk[master])

[Seán C. McCord]

Seán C. McCord has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel, application, and ARI support.
......................................................................


Patch Set 30:

> Patch Set 30:
> 
> > Patch Set 30:
> > 
> > > Patch Set 29:
> > > 
> > > Seán, if you want to take a look at George's feedback about the UUID and give us your thoughts on it, you can comment here or send an email, or reach out to us on IRC, whatever works best for you. If you want to leave it the way it is, the ARI work is done now, and once it goes through the review process it should be good to go.
> > 
> > Ben,
> > 
> > Can you point me to what comments you are talking about?  I seem to be very bad at using this web interface.
> 
> Sure! I'll just post the snippet here:
> 
> "I don't get the need for the UUID to be specified on the channel resource.  If you want a unique ID, simply create your own channel id when you create the channel and write the channel id in the first packet."
> 
> It's up to you whether you want to change it or not. It will work either way.

Ah, I see.  So no, it doesn't necessarily need to be bound at channel creation, but the protocol _does_ require that the first packet be the ID packet.  That was the easiest way I saw to get the ID information to the channel.  I am certainly open to better methods.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 30
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 19:15:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191107/72713884/attachment.html>