[Asterisk-code-review] app_voicemail: now separated into three modules (...asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11416 )

Change subject: app_voicemail: now separated into three modules
......................................................................


Patch Set 1: Code-Review-1

The code needs to be de-duplicated for this to happen.  For example you could create app/voicemail/adsi.c with adsi_* functions, link that into all three modules, do similar moves for other groups of shared code.  I don't really care about de-duplicating the compiled object code for these three modules (they shouldn't be loaded at the same time anyways).  My complaint is that we cannot have 3 copies of the same source code, this would mean that bug fixes would have to be done in 3 places.

We might want to implement an AST_MODULE_INFO `conflicts` field so the module block loading multiple modules.  Currently the 2nd/3rd module will fail to load but only due to duplicate dialplan / AMI stuff.  Need to set load priorities on these to give a deterministic order if someone tries loading all (file system first, odbc next, imap last).

It would be nice to split off odbc/imap modules but I'm not sure it can be done directly from where we are now.  Might be easier to digest if you moved shared code out of app_voicemail.c first / in separate reviews.  Once app_voicemail.c is smaller it might be easier to split the module.  Plus the move of shared code can be done against released versions so this would reduce the diff between branches.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11416
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifac3a909680185778c4fb0dbee6e4a7782642059
Gerrit-Change-Number: 11416
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Tue, 28 May 2019 12:18:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190528/e0910dd6/attachment.html>