[Asterisk-code-review] app_amd: issue with silence suppression fixed (...asterisk[13])

[Nasir Iqbal]

Nasir Iqbal has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11394 )

Change subject: app_amd: issue with silence suppression fixed
......................................................................


Patch Set 1:

I have tested this change and found AMD detection working fine, please check if re-including AST_FRAME_NULL in AMD algorithm, is OK? 

If you are concerned about existing "TOOLONG" bug mentioned in ASTERISK-27610, then please note that excluding AST_FRAME_NULL from AMD algorithm was unnecessary, because following lines which add manual calculation of elapsed time was enough to fix that bug.

		int ms = 0;

		/* Figure out how long we waited */
		if (res >= 0) {
			ms = 2 * maxWaitTimeForFrame - res;
		}

and then using elapsed time as framelength

		framelength = ms;

So I don't see any issue by re-including AST_FRAME_NULL


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11394
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I16ea2d6295bc99b975e8c092e5f9fbd9214debdb
Gerrit-Change-Number: 11394
Gerrit-PatchSet: 1
Gerrit-Owner: Nasir Iqbal <nasir at ictinnovations.com>
Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Nasir Iqbal <nasir at ictinnovations.com>
Gerrit-Comment-Date: Sat, 25 May 2019 23:13:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190525/799180a6/attachment.html>