[Asterisk-code-review] res_prometheus: Add CLI commands (...asterisk[master])

Matt Jordan asteriskteam at digium.com
Wed May 22 08:24:00 CDT 2019


Hello Benjamin Keith Ford, Friendly Automation, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11375

to look at the new patch set (#4).

Change subject: res_prometheus: Add CLI commands
......................................................................

res_prometheus: Add CLI commands

This patch adds a few CLI commands to the res_prometheus module to aid
system administrators setting up and configuring the module. This includes:

* prometheus show status: Display basic statistics about the Prometheus
  module, including its essential configuration, when it was last scraped,
  and how long the scrape took. The last two bits of information are useful
  when Prometheus isn't generating metrics appropriately, as it will at
  least tell you if Asterisk has had its HTTP route hit by the remote
  server.

* prometheus show metrics: Dump the current metrics to the CLI. Useful for
  system administrators to see what metrics are currently available without
  having to cURL or go to Prometheus itself.

ASTERISK-28403

Change-Id: Ic09813e5e14b901571c5c96ebeae2a02566c5172
---
M res/prometheus/bridges.c
A res/prometheus/cli.c
M res/prometheus/endpoints.c
M res/prometheus/prometheus_internal.h
M res/res_prometheus.c
5 files changed, 253 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/75/11375/4
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11375
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic09813e5e14b901571c5c96ebeae2a02566c5172
Gerrit-Change-Number: 11375
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190522/18f8d503/attachment.html>


More information about the asterisk-code-review mailing list