[Asterisk-code-review] res_rtp_asterisk: timestamp should be unsigned instead of signed int (...asterisk[master])

Morten Tryfoss asteriskteam at digium.com
Tue May 21 11:33:32 CDT 2019


Morten Tryfoss has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/11397


Change subject: res_rtp_asterisk: timestamp should be unsigned instead of signed int
......................................................................

res_rtp_asterisk: timestamp should be unsigned instead of signed int

Using timestamp with signed int will cause timestamps exceeding max value
to be negative.
This causes the jitterbuffer to do passthrough of the packet.

ASTERISK-28421

Change-Id: I9dabd0718180f2978856c50f43aac4e52dc3cde9
---
M res/res_rtp_asterisk.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/97/11397/1

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index c4df6a4..ee1e1c4 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -6728,7 +6728,8 @@
 	unsigned int *rtpheader = (unsigned int*)(read_area);
 	struct ast_rtp *rtp = ast_rtp_instance_get_data(instance);
 	struct ast_rtp_instance *instance1;
-	int res = length, hdrlen = 12, seqno, timestamp, payloadtype, padding, mark, ext, cc;
+	int res = length, hdrlen = 12, seqno, payloadtype, padding, mark, ext, cc;
+	unsigned int timestamp;
 	RAII_VAR(struct ast_rtp_payload_type *, payload, NULL, ao2_cleanup);
 	struct frame_list frames;
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11397
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9dabd0718180f2978856c50f43aac4e52dc3cde9
Gerrit-Change-Number: 11397
Gerrit-PatchSet: 1
Gerrit-Owner: Morten Tryfoss <morten at tryfoss.no>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190521/f06152a2/attachment.html>


More information about the asterisk-code-review mailing list