[Asterisk-code-review] app_readexten: new option 'p' to stop reading on '#' key (...asterisk[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11387 )

Change subject: app_readexten: new option 'p' to stop reading on '#' key
......................................................................


Patch Set 2:

I'm curious, in what scenario do you need the '#' key to signal the end of app_readexten? The only scenario I could think of is if you have 2 extensions:

exten => 100,1,Playback(hello-world)
exten => 1001,1,Playback(tt-monkeys)

If you are in the readexten application and you enter "100", it will wait for the timeout before setting the variable to "100" since there is an extension that would match if you entered more digits ("1"). However, it seems like you can already press the "#" key to signal the end of input.

Is there a scenario that you need this for that I'm not thinking of?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11387
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If77c40c9c8b525885730821e768f5dea71cf04c1
Gerrit-Change-Number: 11387
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Tue, 21 May 2019 16:32:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190521/1196d6af/attachment-0001.html>