[Asterisk-code-review] res_prometheus: Add Asterisk bridge metrics (...asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11374 )

Change subject: res_prometheus: Add Asterisk bridge metrics
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/11374/2/res/prometheus/bridges.c 
File res/prometheus/bridges.c:

https://gerrit.asterisk.org/#/c/11374/2/res/prometheus/bridges.c@118 
PS2, Line 118: 	for (i = 0; i < ARRAY_LEN(bridge_metric_defs); i++) {
> And here with the "for" loops again?

Nevermind.  It's not worth it.  You'd have to create an array of string buffers to accumulate the output for each metric.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11374
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie27417dd72c5bc7624eb2a7a6a8829d7551788dc
Gerrit-Change-Number: 11374
Gerrit-PatchSet: 2
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 21 May 2019 13:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190521/23ec7aab/attachment.html>