[Asterisk-code-review] res_prometheus: Add metrics for PJSIP outbound registrations (...asterisk[master])

George Joseph asteriskteam at digium.com
Mon May 20 14:48:07 CDT 2019


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11372 )

Change subject: res_prometheus: Add metrics for PJSIP outbound registrations
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11372/3/res/prometheus/pjsip_outbound_registrations.c 
File res/prometheus/pjsip_outbound_registrations.c:

https://gerrit.asterisk.org/#/c/11372/3/res/prometheus/pjsip_outbound_registrations.c@180 
PS3, Line 180: 			if (!wrapper) {
Don't think this can happen.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11372
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If01420e38530fc20b6dd4aa15cd281d94cd2b87e
Gerrit-Change-Number: 11372
Gerrit-PatchSet: 3
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Comment-Date: Mon, 20 May 2019 19:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190520/59e06791/attachment-0001.html>


More information about the asterisk-code-review mailing list