[Asterisk-code-review] res_rtp_asterisk: Add ability to propose local address in ICE (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11388 )

Change subject: res_rtp_asterisk:  Add ability to propose local address in ICE
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/11388/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/11388/1/res/res_rtp_asterisk.c@6765 
PS1, Line 6765: 	sep = strchr(var->value,',');
              : 		if (sep) {
              : 			*sep = '\0';
              : 			sep++;
              : 			sep = ast_skip_blanks(sep);
              : 			include_local_address = strcmp(sep, "include_local_address") == 0;
              : 		}
> No comment, except to say that C string parsing always makes me sad.

Well, the first 4 lines of this change are strsep(), so I understand your sadness.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11388
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ide492cd45ce84546175ca7d557de80d9770513db
Gerrit-Change-Number: 11388
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 20 May 2019 18:47:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190520/fc64f0a8/attachment-0001.html>