[Asterisk-code-review] app_blind_transfer: new application BlindTransfer (...asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11381 )

Change subject: app_blind_transfer: new application BlindTransfer
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/11381/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11381/1//COMMIT_MSG@11 
PS1, Line 11: 
Can you give a quick use case example here?  Something that explains why someone would use this.


https://gerrit.asterisk.org/#/c/11381/1/apps/app_blind_transfer.c 
File apps/app_blind_transfer.c:

https://gerrit.asterisk.org/#/c/11381/1/apps/app_blind_transfer.c@107 
PS1, Line 107: 
Do we need to check that the channel allows transfer here?  Similar to what app_transfer does?


https://gerrit.asterisk.org/#/c/11381/1/menuselect/example_menuselect-tree 
File menuselect/example_menuselect-tree:

https://gerrit.asterisk.org/#/c/11381/1/menuselect/example_menuselect-tree@13 
PS1, Line 13: 		<member name="app_blind_transfer" displayname="Blind transfer by caller channel" remove_on_change="apps/app_blind_transfer.o apps/app_blind_transfer.so">
Not needed but OK to leave here.


https://gerrit.asterisk.org/#/c/11381/1/menuselect/test/menuselect-tree 
File menuselect/test/menuselect-tree:

https://gerrit.asterisk.org/#/c/11381/1/menuselect/test/menuselect-tree@14 
PS1, Line 14: <member name="app_blind_transfer" displayname="Blind transfer by caller channel" remove_on_change="apps/app_blind_transfer.o apps/app_blind_transfer.so">
Not needed but OK to leave here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11381
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I9d55e7f69ccfd4472dec00d62771d6de8803215a
Gerrit-Change-Number: 11381
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 16 May 2019 13:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190516/2b9d887e/attachment-0001.html>