[Asterisk-code-review] chan_pjsip: Transmit REFER waits for the REFER result setting TRANSF... (...asterisk[master])

[Dan Cropp]

Thanks Joshua.

As I look at it, that does appear to be the case.

Do I place the comments to each line, then hit the main Reply button?
Or should I copy/paste my replies that are in Draft to the main reply?

Dan

-----Original Message-----
From: Joshua C. Colp <jcolp at digium.com> 
Sent: Monday, May 13, 2019 10:17 AM
To: Dan Cropp <dan at amtelco.com>; Matt Fredrickson <creslin at digium.com>; Sungtae Kim <pchero21 at gmail.com>; asterisk-code-review at lists.digium.com
Subject: Re: chan_pjsip: Transmit REFER waits for the REFER result setting TRANSF... (...asterisk[master])

On Mon, May 13, 2019, at 11:53 AM, Dan Cropp wrote:
>  
> My apologies.
> 
> 
> I did reply to several comments. Basically I was looking for some feedback.
> 
> 
> Perhaps the way I replied is not the correct way?
> 
> 
> When I am logged in and look at the comments, I see Joshua’s comment. 
> I hit the reply button and typed in the reply.
> 
> For example, on line 1909 comment. When I click this, I see Joshua’s 
> comment from April 16, 7:53 AM. Below that I see my comment from April
> 17 2:47 PM.
> 
> 
> Is there a better way to ask questions on making the change?
> 
> Or should I just modify the code and submit for a new review to see if 
> I’m going in the right direction?

Did you click the main "Reply" and then "Send"? Without that you are still creating a draft response, and thus the responses can't be seen.

--
Joshua C. Colp
Digium - A Sangoma Company | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com & www.asterisk.org