[Asterisk-code-review] res/ari/resource_channels.c: Added detail hangup reason (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11287 )

Change subject: res/ari/resource_channels.c: Added detail hangup reason
......................................................................


Patch Set 3:

(2 comments)

> Patch Set 2: Code-Review-1
> 
> (2 comments)

Hi Joshua,

Thank you for your kind review.
I've fixed it. :)

https://gerrit.asterisk.org/#/c/11287/2/res/ari/resource_channels.c 
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/#/c/11287/2/res/ari/resource_channels.c@928 
PS2, Line 928: 	cause = AST_CAUSE_NORMAL;
> This isn't needed if you have the else below. You only need one or the other.
Np, I've fixed it. :)


https://gerrit.asterisk.org/#/c/11287/2/res/ari/resource_channels.c@931 
PS2, Line 931: 		cause = atoi(args->reason_code);
> This should use sscanf to do the conversion, and send a 400 if that fails.
sscanf! yes, fixed it. :)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11287
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1cf1d991ffd759d0591b347445a55f416ddc3ff2
Gerrit-Change-Number: 11287
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 09 May 2019 21:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190509/1ec48216/attachment.html>