[Asterisk-code-review] res/ari/resource_channels.c: Added detail hangup reason (...asterisk[master])

sungtae kim asteriskteam at digium.com
Wed May 1 18:26:53 CDT 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11287 )

Change subject: res/ari/resource_channels.c: Added detail hangup reason
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> (1 comment)

Hi Joshua, thank you for your kind review, always. :)

Btw, I don't agree with about generally not used part... 

Simply imagine, if the inbound call/channel executes the stasis and connected with other channel using the bridge. And it needs to be hung up with the same hangup cause with the bridged channel.
Then it might have a challenge.

I think this will happen a lot - delivering the same hangup code to the other channel.

Anyways, I can see the DELETE /channel was not designed for this kind of use case. But could you please consider this once again?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11287
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1cf1d991ffd759d0591b347445a55f416ddc3ff2
Gerrit-Change-Number: 11287
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 01 May 2019 23:26:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190501/3db42ac9/attachment.html>


More information about the asterisk-code-review mailing list