[Asterisk-code-review] build: 'postgresql_using' was causing problems. (...asterisk[13])

Benjamin Keith Ford asteriskteam at digium.com
Fri Mar 29 14:45:51 CDT 2019


Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11208 )

Change subject: build: 'postgresql_using' was causing problems.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Shouldn't this python script also check if the user has permissions to alter the table? Cause if it doesn't have the corresponding permission it will trigger an error.

Permissions are set up according to the user, and specified in the .ini file used to upgrade and downgrade. The upgrade and downgrade themselves are not responsible for database permissions.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11208
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I7fdde0efa33ad91e761512bc2e2d0bab02cb6baf
Gerrit-Change-Number: 11208
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Fri, 29 Mar 2019 19:45:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190329/93223cc5/attachment.html>


More information about the asterisk-code-review mailing list