[Asterisk-code-review] testsuite: Added testcase for channels/{channelId}/rtp_statistics (...testsuite[master])

sungtae kim asteriskteam at digium.com
Thu Mar 28 17:57:14 CDT 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/11178 )

Change subject: testsuite: Added testcase for channels/{channelId}/rtp_statistics
......................................................................


Patch Set 2:

(2 comments)

Hi Joshua,

Thank you for your kind reviewing.

I've fixed it as your comment. :)

https://gerrit.asterisk.org/#/c/11178/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11178/1//COMMIT_MSG@10 
PS1, Line 10: 
> This should include the ASTERISK issue
NP, added it.


https://gerrit.asterisk.org/#/c/11178/1/tests/rest_api/channels/rtp_statistics/basic/test-config.yaml 
File tests/rest_api/channels/rtp_statistics/basic/test-config.yaml:

https://gerrit.asterisk.org/#/c/11178/1/tests/rest_api/channels/rtp_statistics/basic/test-config.yaml@86 
PS1, Line 86: uri: 'rtp_statistics'
> This request will fail, as it's not the full URI for rtp_statistics for the channel. […]
Right, fixed it.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11178
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ie41127219a4fccc183f9374fbcb768835a7d2bb2
Gerrit-Change-Number: 11178
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 22:57:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190328/08b9bad2/attachment-0001.html>


More information about the asterisk-code-review mailing list