[Asterisk-code-review] pjsip: restrict function PJSIP_PARSE_URI to parse only SIP/SIPS URIs (...asterisk[16])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11177 )

Change subject: pjsip: restrict function PJSIP_PARSE_URI to parse only SIP/SIPS URIs
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/11177/1/channels/pjsip/dialplan_functions.c 
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/11177/1/channels/pjsip/dialplan_functions.c@1127 
PS1, Line 1127: 	if (!uri || (!PJSIP_URI_SCHEME_IS_SIP(uri) && !PJSIP_URI_SCHEME_IS_SIPS(uri))) {
> I think this should go below the "scheme" and "display" checks, as those would be supported for non- […]
I think function PJSIP_PARSE_URI should support only SIP URI.
The pjsip_parse_uri does not correctly support other types of URI.
For example for '192.168.1.1:5060' the "scheme" will be '192.168.1.1' and "content" will be '5060'.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11177
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I16f255c2b86a80a67e9f9604b94b129a381dd25e
Gerrit-Change-Number: 11177
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 27 Mar 2019 14:43:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190327/e592562e/attachment.html>