[Asterisk-code-review] app_queue: Fix a few member pause bugs (...asterisk[16])

Sean Bright asteriskteam at digium.com
Tue Mar 26 14:21:40 CDT 2019


Hello Friendly Automation, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11170

to look at the new patch set (#2).

Change subject: app_queue: Fix a few member pause bugs
......................................................................

app_queue: Fix a few member pause bugs

* When setting member->paused, make sure to always set member->lastpaused
  and member->reason_paused if applicable. Created a simple wrapper
  function to handle this.

* When printing the time the member was paused, use member->lastpaused,
  regardless of a reason phrase being present or not.

* When emitting the QueueMemberPause event, set the PausedReason field
  as documented, instead of the Reason field.

ASTERISK-27541 #close
Reported by: César Benjamín García Martínez

ASTERISK-28349 #close
Reported by: Niksa Baldun

Change-Id: I80507e05e3c9bc61843104c405a9ed9c0de1594e
---
M apps/app_queue.c
1 file changed, 23 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/70/11170/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11170
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I80507e05e3c9bc61843104c405a9ed9c0de1594e
Gerrit-Change-Number: 11170
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190326/6e4b31cd/attachment.html>


More information about the asterisk-code-review mailing list