[Asterisk-code-review] main/json.c: Added app_name, app_data to channel type (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11164 )

Change subject: main/json.c: Added app_name, app_data to channel type
......................................................................


Patch Set 5:

> Patch Set 4: Code-Review-1
> 
> You reported the original issue against the 16 branch but because you changed the prototype of ast_json_dialplan_cep, this change can only go into master.  If that's what you intended, that's OK.  If you need it in 16, you'll need to create a new variant of ast_json_dialplan_cep that has the additional parameters and leave the existing one for backwards compatibility.

Hi George,

Thank you for you kind reviewing. :)

Yes, I agree with that. Fixed it add the ast_json_dialplan_cep's variant and made it referenced to variant.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11164
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia48972b3850e5099deab0faeaaf51223a1f2f38c
Gerrit-Change-Number: 11164
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 23:52:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190325/391c8e0d/attachment-0001.html>