[Asterisk-code-review] main/pbx.c: Fixed to call the ast_softhangup() (...asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11149 )

Change subject: main/pbx.c: Fixed to call the ast_softhangup()
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11149/3/main/pbx.c 
File main/pbx.c:

https://gerrit.asterisk.org/#/c/11149/3/main/pbx.c@4562 
PS3, Line 4562: 	ast_softhangup(c, AST_SOFTHANGUP_APPUNLOAD);
I don't think this is the correct fix. Based on your explanation of the scenario I would expect the code within the if to be executed since it's back in the dialplan like normal. I think the no_hangup_chan field should be set to 0 in res/res_stasis.c based on what you've said and what I'm reading about it.

Changing that and seeing the implications would be good.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 11:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190325/f7a5aa49/attachment.html>