[Asterisk-code-review] res/res_ari_channels.c: Added new ARI /ari/channels/<channelId>/dump (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11162 )

Change subject: res/res_ari_channels.c: Added new ARI /ari/channels/<channelId>/dump
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Hm.. I have thinking about that, but couldn't get good answer for
>  > result json format.
>  > 
>  > Because 'channel' datatype is used too many places. So, I don't
>  > feeling good to fixing(adding) these stuffs into channel datatype.
>  > 
>  > And changing this like /asterisk/info,
>  > "Channel": {
>  > "channel": {
>  > ...
>  > },
>  > "detail": {
>  > ...
>  > }
>  > }
>  > 
>  > is also changing the result structure of /channels/<channelId>.
>  > 
>  > Hm... what is this should be? I think adding new ARI like this, is
>  > not that bad, compare to changing existing one.
> 
> Adding attributes to existing JSON responses is OK as long as the overall structure and existing properties aren't changed. You could add the "detail" object as a property on the existing Channel object.

Hi George,

Thank you for your kind reviewing. Ah, so, it's OK to add the object into the Channel. I'll fix it. :)


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11162
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie5b6c8b20a2bda5168ea56114f4241bc818cab10
Gerrit-Change-Number: 11162
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 19 Mar 2019 22:34:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190319/c512bd3e/attachment.html>