[Asterisk-code-review] res/res_ari_channels.c: Added new ARI /ari/channels/<channelId>/dump (...asterisk[master])

sungtae kim asteriskteam at digium.com
Mon Mar 18 15:44:02 CDT 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11162 )

Change subject: res/res_ari_channels.c: Added new ARI /ari/channels/<channelId>/dump
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> Why not just enhance the output of channel GET rather than creating a new API?  If you really needed to, you could add a parameter to the GET to indicate that you wanted the extended detail.

Good point. You're right. I will add more parameter.

Will be like GET /ari/channels/<channel_id>?detail=true


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11162
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie5b6c8b20a2bda5168ea56114f4241bc818cab10
Gerrit-Change-Number: 11162
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 18 Mar 2019 20:44:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190318/f2c8ad55/attachment.html>


More information about the asterisk-code-review mailing list