[Asterisk-code-review] sorcery.c: Sorcery enhancements for wizard management (...asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11154 )

Change subject: sorcery.c: Sorcery enhancements for wizard management
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11154/4/main/sorcery.c 
File main/sorcery.c:

https://gerrit.asterisk.org/#/c/11154/4/main/sorcery.c@820 
PS4, Line 820: #define WIZARD_NAME_COMPARE(a, b) ()
             : 		if (strcmp(wizard->wizard->callbacks.name, wizard_type_name) == 0
             : 			&& strcmp(S_OR(wizard->wizard_args, ""), S_OR(wizard_args, "")) == 0) {
             : 			ao2_cleanup(AST_VECTOR_REMOVE_ORDERED(&object_type->wizards, i));
             : 			res = 0;
             : 			break;
             : 		}
             : #undef WIZARD_NAME_COMPARE
This macro appears to be unused between the define and undef, so should be removed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11154
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605
Gerrit-Change-Number: 11154
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 18 Mar 2019 16:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190318/19bd0a6c/attachment.html>