[Asterisk-code-review] res/res_ari: Added timestamp as a requirement for all ARI events (...asterisk[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11100 )

Change subject: res/res_ari: Added timestamp as a requirement for all ARI events
......................................................................


Patch Set 5:

> Patch Set 5:
> 
> > Patch Set 4: Code-Review-1
> > 
> > The "ApplicationMoveFailed" generated in res/res_stasis.c also needs a timestamp.
> 
> Thanks. Iv'e added timestamp for that.
> 
> Btw, I'm not happy with
> 
> if (!msg) {
>   ...
> } else {
>   ...
> }
> 
> fixes in the res/res_stasis.c file. Couldn't catch up how the exit the loop in a correct way if msg could not created. So, I've added this silly if statement. Please let me know if there's correct way or may make it another ticket for fix this.

It may seem silly, but I believe you are correct; there does not appear to be a good way to break out of this if the msg was not created. The if/else should be fine!


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11100
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I382c2fef58f5fe107e1074869a6d05310accb41f
Gerrit-Change-Number: 11100
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 18 Mar 2019 14:44:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190318/f2ac082f/attachment.html>