[Asterisk-code-review] testsuite: Fix race condition for rest_api/move. (...testsuite[13])

Friendly Automation asteriskteam at digium.com
Mon Mar 18 06:29:46 CDT 2019


Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/testsuite/+/11157 )

Change subject: testsuite: Fix race condition for rest_api/move.
......................................................................

testsuite: Fix race condition for rest_api/move.

Before, the test was being stopped after the channel was destroyed. This
would sometimes fail the test, since the ChannelDestroyed event would
call stop_test and occasionally the last StasisEnd event we needed for
the test to pass would not be seen. Since we actually care about the
StasisEnd event, stop the test on it rather than ChannelDestroyed.

Change-Id: I477286b4b49522ee8e3f808e090e3800ae2d269d
---
M tests/rest_api/move/test-config.yaml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/rest_api/move/test-config.yaml b/tests/rest_api/move/test-config.yaml
index c4c23b1..8fdf5c9 100644
--- a/tests/rest_api/move/test-config.yaml
+++ b/tests/rest_api/move/test-config.yaml
@@ -30,8 +30,8 @@
     -
         ari-events:
             match:
-                type: ChannelDestroyed
-                application: testsuite
+                type: StasisEnd
+                application: multiple-args
                 channel:
                     id: 'testsuite-default-id'
         stop_test:

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11157
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-Change-Id: I477286b4b49522ee8e3f808e090e3800ae2d269d
Gerrit-Change-Number: 11157
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190318/064ec7c3/attachment.html>


More information about the asterisk-code-review mailing list