[Asterisk-code-review] Revert "Test_cel: Fails when DONT_OPTIMIZE is off" (...asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Mar 18 06:05:31 CDT 2019


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11146 )

Change subject: Revert "Test_cel: Fails when DONT_OPTIMIZE is off"
......................................................................

Revert "Test_cel: Fails when DONT_OPTIMIZE is off"

This reverts commit 1c8378bbc9639739c079df37897ff02f94af0f07.

Change-Id: I1b9227b263c3dc4246a50aebf52a7640a0f7ea07
---
M include/asterisk/strings.h
M main/strings.c
2 files changed, 13 insertions(+), 16 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/include/asterisk/strings.h b/include/asterisk/strings.h
index 62e5b85..c56a139 100644
--- a/include/asterisk/strings.h
+++ b/include/asterisk/strings.h
@@ -1212,7 +1212,19 @@
  *
  * \retval str for convenience
  */
-char *attribute_pure ast_str_to_lower(char *str);
+static force_inline char *attribute_pure ast_str_to_lower(char *str)
+{
+	char *str_orig = str;
+	if (!str) {
+		return str;
+	}
+
+	for (; *str; ++str) {
+		*str = tolower(*str);
+	}
+
+	return str_orig;
+}
 
 /*!
  * \brief Convert a string to all upper-case
diff --git a/main/strings.c b/main/strings.c
index d3473d8..0cd4692 100644
--- a/main/strings.c
+++ b/main/strings.c
@@ -430,18 +430,3 @@
 
 	return 0;
 }
-
-char *attribute_pure ast_str_to_lower(char *str)
-{
-	char *str_orig = str;
-	if (!str) {
-		return str;
-	}
-
-	for (; *str; ++str) {
-		*str = tolower(*str);
-	}
-
-	return str_orig;
-}
-

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11146
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1b9227b263c3dc4246a50aebf52a7640a0f7ea07
Gerrit-Change-Number: 11146
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190318/13610715/attachment.html>


More information about the asterisk-code-review mailing list