[Asterisk-code-review] sorcery.c: Sorcery enhancements for wizard management (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11154 )

Change subject: sorcery.c: Sorcery enhancements for wizard management
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/11154/3/include/asterisk/sorcery.h 
File include/asterisk/sorcery.h:

https://gerrit.asterisk.org/#/c/11154/3/include/asterisk/sorcery.h@576 
PS3, Line 576: AST_SORCERY_WIZARD_APPLY_NONE = (0 << 0),
             : 	AST_SORCERY_WIZARD_APPLY_CACHING = (1 << 0),
             : 	AST_SORCERY_WIZARD_APPLY_READONLY = (1 << 1),
             : 	AST_SORCERY_WIZARD_APPLY_ALLOW_DUPLICATE = (1 << 2)
I think these should be documented a bit more, specifically on what behavior each will have.


https://gerrit.asterisk.org/#/c/11154/3/main/sorcery.c 
File main/sorcery.c:

https://gerrit.asterisk.org/#/c/11154/3/main/sorcery.c@830 
PS3, Line 830: 	if (index_to_remove >= 0) {
             : 		ao2_cleanup(AST_VECTOR_REMOVE_ORDERED(&object_type->wizards, index_to_remove));
             : 		res = 0;
             : 	}
Just curious - why did you do it this way instead of removing within the for loop?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11154
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605
Gerrit-Change-Number: 11154
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 18 Mar 2019 10:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190318/46801558/attachment.html>