[Asterisk-code-review] res/res_stasis: Fixed wrong StasisEnd timestamp (...asterisk[16])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11134 )

Change subject: res/res_stasis: Fixed wrong StasisEnd timestamp
......................................................................


Patch Set 5:

(2 comments)

> Patch Set 4: Code-Review-1
> 
> (2 comments)

Fixed it!

https://gerrit.asterisk.org/#/c/11134/4/res/res_stasis.c 
File res/res_stasis.c:

https://gerrit.asterisk.org/#/c/11134/4/res/res_stasis.c@126 
PS4, Line 126: 	msg = ast_json_pack("{s: s, s: o, s: o}",
             : 		"type", "StasisEnd",
             : 		"timestamp", ast_json_copy(ast_json_object_get(payload->blob, "timestamp")),
> Here this can use the other method like you had before of bumping the ref. […]
I've checked that. Fixed it. :)


https://gerrit.asterisk.org/#/c/11134/4/res/res_stasis.c@158 
PS4, Line 158: 	msg = ast_json_pack("{s: s, s: o, s: o, s: o}",
             : 		"type", "StasisStart",
             : 		"timestamp", ast_json_copy(ast_json_object_get(payload->blob, "timestamp")),
             : 		"args", ast_json_deep_copy(ast_json_object_get(payload->blob, "args")),
> Similar to above. This can be undone and as it should use the ref bump method.
Np, fixed it. :)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11134
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5eb8380fc472f1100535a6bc4983c64767026116
Gerrit-Change-Number: 11134
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 21:41:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190315/4c0fe0c9/attachment-0001.html>