[Asterisk-code-review] res/res_stasis: Fixed wrong StasisEnd timestamp (...asterisk[13])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11133 )

Change subject: res/res_stasis: Fixed wrong StasisEnd timestamp
......................................................................


Patch Set 2:

(2 comments)

> Patch Set 2: Code-Review-1
> 
> (2 comments)

Hi Kevin, thank you for your kind reviewing. I was totally wrong. As you mentioned it the message creating was failed because there's no timestamp for that.

I'm so sorry about my bad commit. :'(

https://gerrit.asterisk.org/#/c/11133/2/res/res_stasis.c 
File res/res_stasis.c:

https://gerrit.asterisk.org/#/c/11133/2/res/res_stasis.c@128 
PS2, Line 128: 	msg = ast_json_pack("{s: s, s: o, s: o}",
> I believe this is now correct combined with the "ast_json_copy" of the object. […]
I can your point, I've fixed it.


https://gerrit.asterisk.org/#/c/11133/2/res/res_stasis.c@130 
PS2, Line 130: 		"timestamp", ast_json_copy(ast_json_object_get(payload->blob, "timestamp")),
> I still don't think this is getting any kind of timestamp (but could be misreading the code). […]
You were totally right. I was wrong.

I was misreading the code and didn't test it correctly. As you mentioned it, there was no timestamp setting in the code.

Fixed it correctly.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11133
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I5eb8380fc472f1100535a6bc4983c64767026116
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 21:41:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190315/c795dd85/attachment.html>