[Asterisk-code-review] sorcery.c: Sorcery enhancements for wizard management (...asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11154 )

Change subject: sorcery.c: Sorcery enhancements for wizard management
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11154/1/main/sorcery.c 
File main/sorcery.c:

https://gerrit.asterisk.org/#/c/11154/1/main/sorcery.c@856 
PS1, Line 856: 		if (found && strcmp("memory", wizard_name)) {
Referencing a specific dependent by "name" doesn't seem right. Barring any other way I'd rather see a flag added to the object wizard struct marking if that type is allowed or not.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11154
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605
Gerrit-Change-Number: 11154
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 19:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190315/9a9fe285/attachment.html>