[Asterisk-code-review] chan_sip, chan_iax2, chan_pjsip: Allow updating variable values. (...asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10930 )

Change subject: chan_sip, chan_iax2, chan_pjsip: Allow updating variable values.
......................................................................


Patch Set 6:

> Patch Set 6:
> 
> > Patch Set 6:
> > 
> > General question: Because of the duplication between the two channel driver files, would it make sense to make this an ast_var_* function in main/config.c and consume it in these two files instead?
> 
> Maybe, is this a specific request for this change to the patch so it can go ahead?
> 
> Anyway, I'll see if I can make such a change in the next few days.

Yes, this is request for that change.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10930
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie1897a96c82b8945e752733612ee963686f32839
Gerrit-Change-Number: 10930
Gerrit-PatchSet: 6
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 17:46:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190312/c03bcf8d/attachment.html>